Skip to content

[release-4.14] OCPBUGS-61176: Add missing service network DNS entries to KAS cert - #6742

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-6394-to-release-4.14
Sep 3, 2025
Merged

[release-4.14] OCPBUGS-61176: Add missing service network DNS entries to KAS cert#6742
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-6394-to-release-4.14

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 2, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #6394

/assign csrwng

@csrwng openshift-cherrypick-robot
Add missing service network DNS entries to KAS cert
726ee35 
PR openshift#6114 backported code that did not include the service network DNS entries for the kube apiserver. This was ok in releases 4.17 and newer because in those releases a separate certificate is created to serve those service network DNS entries. However in 4.16 and older, there is only one serving certificate for the kube apiserver. This resulted in clients like ACM failing to communicate with the kube apiserver because they use the service network endpoint to install the klusterlet in the hosted cluster. This fix adds the missing entries back into the dns names of the KAS serving certificate.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2025
Merged
4 tasks
@coderabbitai

coderabbitai Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci
openshift-ci Bot requested review from enxebre and sjenning September 2, 2025 21:47
@csrwng

csrwng commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

/area control-plane-operator
/approve
/lgtm

@openshift-ci openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-area labels Sep 2, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58506 has been cloned as Jira Issue OCPBUGS-61176. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-61176: Add missing service network DNS entries to KAS cert

Details

In response to this:

This is an automated cherry-pick of #6394

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@openshift-ci openshift-ci Bot changed the title [release-4.14] OCPBUGS-58506: Add missing service network DNS entries to KAS cert [release-4.14] OCPBUGS-61176: Add missing service network DNS entries to KAS cert Sep 2, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61176, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58506 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-58506 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yli2@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6394

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/retest

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 3, 2025
@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/retest

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/verified later

@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2025

Copy link
Copy Markdown

@csrwng: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/verified later @csrwng

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 3, 2025
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2025

Copy link
Copy Markdown

@csrwng: This PR has been marked to be verified later by @csrwng.

Details

In response to this:

/verified later @csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/override "Red Hat Konflux / control-plane-operator-4-14-on-pull-request"

@openshift-ci

openshift-ci Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux / control-plane-operator-4-14-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / control-plane-operator-4-14-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/override "Red Hat Konflux / hypershift-release-414-on-pull-request"

@openshift-ci

openshift-ci Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux / hypershift-release-414-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hypershift-release-414-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csrwng

csrwng commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

The current HO is no longer compatible with a 4.14 management cluster, preventing installation for the kubevirt test.
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

@openshift-ci

openshift-ci Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

The current HO is no longer compatible with a 4.14 management cluster, preventing installation for the kubevirt test.
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-aws-ovn-reduced 726ee35 link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-kubevirt-aws-ovn 726ee35 link false /test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit b11c804 into openshift:release-4.14 Sep 3, 2025
11 of 14 checks passed
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-61176: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-61176 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6394

/assign csrwng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Sep 4, 2025

Copy link
Copy Markdown

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.14.0-202509041817.p0.gb11c804.assembly.stream.el8.
All builds following this will include this PR.

@openshift-merge-robot

openshift-merge-robot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2025-09-04-225553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre
@sjenning sjenning Awaiting requested review from sjenning

Assignees

@csrwng csrwng

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @csrwng @openshift-ci-robot @openshift-bot @openshift-merge-robot